Spotted a copy-paste typo in the dns-server-tester go.mod

Platform Bug Reports
1

Hey team,

I was reading the source code for the DNS tester and noticed a naming collision.

It looks like a bit of copy-paste debt from the grep challenge, the go.mod for the DNS tester is currently identifying itself as the grep-tester dns-server-tester/go.mod at e491a49873be71b5810e0e67525d16d6b3e1a5e1 · codecrafters-io/dns-server-tester · GitHub

This also flows into the internal imports and the Makefile.

I’ve raised a PR to tidy this up so it correctly identifies as dns-server-tester, which should help avoid naming collisions .

PR Link: chore: fix incorrect module naming and internal paths by dhotrey · Pull Request #36 · codecrafters-io/dns-server-tester · GitHub

Also, I noticed that in the Makefiles for most of the testers, the copy_course_file directive points to /repo/build-your-own-<x>/contents/course-definition.yml, but in practice, in most repos, it has been moved to the root: /repo/build-your-own-<x>/course-definition.yml.

example from http-server-tester :

copy_course_file:
	hub api \
		repos/codecrafters-io/build-your-own-http-server/contents/course-definition.yml \
		| jq -r .content \
		| base64 -d \
		> internal/test_helpers/course_definition.yml

If you guys give me the go-ahead, I don’t mind fixing and raising a PR for this pattern across the other testers as well!

4

Hey @dhotrey, thanks for catching this, and for putting together the PR! I’ve merged it now.

Feel free to fix the same issue in the other tester repos, and just tag me to merge them. Looks like it affects three other repos.