Failing Stage Despite Meeting Requirements

Challenges
1

I’m stuck on Stage #NI6 on the C++ version of the shell challenge.

It fails at the echo command for not giving the correct text despite the fact that I am providing the exact text.

Here are my logs:

remote: [your-program] $ echo script     example
remote: [your-program] script     example
remote: [tester::#NI6] Output does not match expected value.
remote: [tester::#NI6] Expected: "script example"
remote: [tester::#NI6] Received: "script     example"

This is explicitly what the task asks for, so I’m not sure what it wants:

$ echo 'shell hello'
shell hello
$ echo 'world     test'
world     test
$

Here’s the function I use for the echo command:

void echo(std::string input) {
    std::string short_inp = input.substr(5);
    std::string quote_text;
    int inc = short_inp.size() - 1;
    if ((short_inp[0] == '\'' && short_inp[inc] == '\'') || (short_inp[0] == '\"' && short_inp[inc] == '\"')) {
        for (int j = 1; j < inc; j++) {
            quote_text.push_back(short_inp[j]);
        } 
        short_inp = quote_text;
    }
    std::cout << short_inp << std::endl;
}

Any idea on what I should do?

4

Hey @Simmo0n, multiple spaces between arguments should collapsed into a single space:

image
image2002×482 73.1 KB

You can try this in a real shell:

image
image986×132 12.9 KB

6

I’ve edited it but now, despite the fact that it seemingly returns the correct result it still fails testing.
Here is the testing result:

remote: [tester::#NI6] Expected: "script test"
remote: [tester::#NI6] Received: "script     test"

..and here is the result I get when I test the shell (testing all types):

$ echo script     test
script test
$ echo "script     test"
script test
$ echo 'script     test'
script test
$
7

Could you upload your code to GitHub and share the link? It will be much easier to debug if I can run it directly.

$ echo "script     test"
script test
$ echo 'script     test'
script test

BTW, spaces within quotes should be preserved:

image
image856×244 21.8 KB

8

Your first and last examples seem to contradict each other.

  • For your initial post, consider what happens if your if statement does not trigger. Then you output short_inp which is everything after the echo as one string. But as Andy says, unquoted separate words should only have one space.

So when the test says it expected only a single space, but it received one with multiple spaces, then at least based on the code you provided the test is correct.

remote: [tester::#NI6] Expected: "script example"
remote: [tester::#NI6] Received: "script     example"
  • For your second post, you output what you shell writes. But space within quoted works should be kept. So you your shell should instead output this:
$ echo script     test
script test
$ echo "script     test"
script     test
$ echo 'script     test'
script     test

You may want to consider your input as a sequence of words. Consider also that .sh allows strange things like:

$ echo "Hello Wo""rld"
Hello World
1 Like