Stage #IF6 case sensitive stdout test

harveysanders · May 8, 2024, 2:41pm

I’m stuck on stage 4 of the Docker challenge in Go.

I believe the assertion for FS isolation should be case-insensitive. I think my current stdout output should pass:

remote: [stage-4] Expected stdout to contain "No such file or directory", got: "Err: fork/exec /usr/local/bin/docker-explorer: no such file or directory"

However, the assertion is checking for an uppercase “N” in “No” here:

github.com

codecrafters-io/docker-tester/blob/18245703a5beed8ee0a7e1cbb7204a7ee3b3b5d1/internal/stage_fs_isolation.go#L29


      
          	logger.Debugf("(expecting that the directory won't be accessible)")
          
          	result, err := executable.Run(
          		"run", DOCKER_IMAGE_STAGE_1,
          		"/usr/local/bin/docker-explorer", "ls", tempDir,
          	)
          	if err != nil {
          		return err
          	}
          
          	if err = assertStdoutContains(result, "No such file or directory"); err != nil {
          		return err
          	}
          
          	if err = assertExitCode(result, 2); err != nil {
          		return err
          	}
          
          	return nil
          }

if err = assertStdoutContains(result, "No such file or directory"); err != nil {
	return err
}

Maybe this is intentional, but it seems like a simple mistake.

Thanks for building this great tool! : )

rohitpaulk · May 8, 2024, 3:17pm

@harveysanders thanks for reporting!

The error here is misleading for sure, the reason here is that “no such file or directory” is an error string originating from your program, instead of from docker-explorer ls. If docker-explorer ls was successfully executed, its output would include the capital N when a directory isn’t found.

Definitely has to be a way to make the tester more friendly here… Maybe by testing ls on a known directory first before testing the invalid directory case. Will see what we can do!

harveysanders · May 8, 2024, 4:05pm

Ah thanks for the quick reply! I see what you mean now, looking at the docker-explorer source:

github.com

codecrafters-io/docker-explorer/blob/1d4263cb97913070484bb15a88c1a243824efc09/main.go#L80


      
          func commandMyPID() {
          	pid := os.Getpid()
          	fmt.Println(pid)
          }
          
          func commandLs() {
          	checkArgCountAtleast(2)
          	files, err := ioutil.ReadDir(os.Args[2])
          	if err != nil {
          		if os.IsNotExist(err) {
          			fmt.Printf("No such file or directory\n")
          			os.Exit(2) // Matches what 'ls' does
          		} else {
          			fmt.Printf("Error: %v", err)
          			os.Exit(1)
          		}
          	}
          
          	for _, file := range files {
          		fmt.Println(file.Name())
          	}

Maybe it would help to include the name of the executed command in the assertion? For example, on my system (zsh on OSX), i’d get this output with ls

$ ls /not-a-dir
ls: /not-a-dir: No such file or directory

Including the executed command and the path might give the dev just enough clues to understand their code is off. That would require an upstream change on docker-explorer as well though.

Anyway, thanks again for the reply and the helpful explanation!

system · May 13, 2024, 4:05pm

This topic was automatically closed 5 days after the last reply. New replies are no longer allowed.

system · June 4, 2024, 2:32am

Note: I’ve updated the title of this post to include the stage ID (#IF6). You can learn about the stages rename here: Upcoming change: Stages overhaul.

Topic		Replies	Views
Docker Challenge #KF3 Challenges challenge:docker	1	52	June 17, 2024
"Build your own shell" - Stage #IP1 (golang): Expected outpout to match Challenges challenge:shell	3	100	June 8, 2024
Final step on Shell (golang) is not passing - stuck and suspect test error Challenges challenge:shell	8	220	May 30, 2024
Test bug works fine localy Challenges challenge:shell	2	64	June 28, 2024
Git test failing with Typescript on stage 4 Challenges challenge:git	4	102	May 28, 2024

Stage #IF6 case sensitive stdout test

Related Topics