In Rust for the #YT5 tests to pass I had to implement the next two stages. That seemed obvious looking at the test logs as the test is sending double quoted string with escape characters, which are not supposed to be implemented at this time but in the next stage.
I believe this test should be fixed to avoid relying on future behavior.
Hey @pykoder, thanks for the report!
Would you mind sharing a bit more about the issue you ran into on stage #YT5 (Backslash outside quotes)? In particular, which test case made you implement the next two stages as well? Thanks!
Just for reference, here’s what the tests for stage #YT5 look like:
cat “/tmp/bee/f\n45” “/tmp/bee/f\36” “/tmp/bee/f’\’38”
It failed with my code because to implement “Backslash outside quotes” I had not yet implemented the double quoted string behavior, but not with the same default as expected in the test. In my implementation backslash was just ignored at that stage when inside double quoted string as anywhere else. As nothing was told about the expected behavior inside quoted string I thought it was as good an option as any.
I believe you should either fix the test suite like: cat /tmp/bee/f\\n45 /tmp/bee/f\\36 /tmp/bee/f’\\’38 or state in the “Backslash Outside quotes” stage statement that the backslash must be treated as is and sent in the string when inside quotes. I prefer the first option but either way would be okay.
@pykoder Gotcha, thanks for the detailed clarification (and for proposing concrete fixes)!
We’ll adjust the test suite so it doesn’t depend on future stages. I’ll keep you posted once the fix is shipped.
@pykoder We’ve just pushed a fix in this PR. Thanks again for highlighting the issue! Let us know if you spot anything else.
This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.
