In the BinSpec example for the log file, on Record Batch #1, The CRC value in the comment is stated as
In this case, the value is 0x24db12dd , which is 618336989 in decimal.
However, the value shown in the BinSpec is
0xb069457c (`-1335278212 `)
Is this a typo or am I misreading the comment?
codecrafters-io/binspec/blob/main/binspec-visualizer/app/data/formats/kafka-cluster-metadata.yml#L22-L25
codecrafters-io/binspec/blob/f6906842e78e621b75f688ddc94e3962e33c129f/binspec-visualizer/app/data/formats/kafka-cluster-metadata.yml#L397
The paths at the bottom are links to the BinSpec code on GitHub. The forum would not let me post URLs from GitHub
andy1li
3
Hi @harveysanders, thanks for highlighting the issue! We’ll investigate the issue and keep you updated with any progress.
andy1li
5
We’ve fixed the typo in this PR. Thanks again for highlighting the issue! @harveysanders
there seems to be another typo here, should the value be 1 or 0 here?
I also found a similar issue with the partition ID, might have to go through the entire binspec to ensure that there aren’t other similar errors.
