Incorrect test on EZ5 stage

gnomeby · May 24, 2024, 8:49pm

I’m stuck on Stage #EZ5.

Here are my logs:

Expected output to contain "nonexistent not found\\n", got "nonexistent: command not found\r\n$ "

“nonexistent not found” is incorrect answer for real console.

rohitpaulk · May 24, 2024, 9:14pm

@gnomeby nice catch! I’ve updated the instructions. The test expectations are correct (we run them against bash, zsh and dash to be sure):

Commit with instruction changes:

gnomeby · May 24, 2024, 9:19pm

My Gentoo:

type erer
bash: type: erer: not found

bash 5.1_p16-r6

and

sh-5.1$ type erer
sh: type: erer: not found

But OK I can use your variant.

gnomeby · May 24, 2024, 9:22pm

dash 0.5.12

# type r
r: not found

rohitpaulk · May 24, 2024, 9:22pm

Aha… Looks like we’ve handled this in tests to make it compatible with all shells:

github.com

codecrafters-io/shell-tester/blob/925d3b08b9e4d390fe3abc9cf0885b79a912def1/internal/stage6.go#L43


      
          		}
          	}
          
          	invalidCommands := []string{"nonexistent", "nonexistentcommand"}
          
          	for _, invalidCommand := range invalidCommands {
          		command := fmt.Sprintf("type %s", invalidCommand)
          
          		testCase := test_cases.RegexTestCase{
          			Command:                    command,
          			ExpectedPattern:            regexp.MustCompile(fmt.Sprintf(`%s[:]? not found\r\n`, invalidCommand)),
          			ExpectedPatternExplanation: fmt.Sprintf("contain %q", fmt.Sprintf(`%s not found\n`, invalidCommand)),
          			SuccessMessage:             "Received expected response",
          		}
          		if err := testCase.Run(shell, logger); err != nil {
          			return err
          		}
          	}
          
          	return assertShellIsRunning(shell, logger)
          }

I assume bash is far more widely used than zsh, so I think we’ll use the format you shared in the instructions then. Thanks for highlighting this, will update in the instructions!

rohitpaulk · June 10, 2024, 1:04pm

Fixed!

system · June 15, 2024, 1:05pm

This topic was automatically closed 5 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Expected shell to be a long-running process, but it exited... Test failed Challenges challenge:shell	3	49	October 30, 2024
Test bug works fine localy Challenges challenge:shell	2	136	June 28, 2024
Test Case failing for #IP1 Challenges challenge:shell	4	31	December 15, 2024
Tests won't pass on #MG5 Challenges challenge:shell	9	58	December 19, 2024
Final step on Shell (golang) is not passing - stuck and suspect test error Challenges challenge:shell	8	256	May 30, 2024

Incorrect test on EZ5 stage

Related topics