# Grep: Shouldn't be added more test to be correct?

**URL:** <https://forum.codecrafters.io/t/grep-shouldnt-be-added-more-test-to-be-correct/1809>\
**Category:** Challenges\
**Tags:** challenge:grep\
**Created:** [September 17, 2024, 9:10am UTC](https://forum.codecrafters.io/t/grep-shouldnt-be-added-more-test-to-be-correct/1809 "2024-09-17T09:10:34Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![giuseppe-osenda](https://yyz1.discourse-cdn.com/flex003/user_avatar/forum.codecrafters.io/giuseppe-osenda/32/1734_2.png) [@giuseppe-osenda](https://forum.codecrafters.io/u/giuseppe-osenda)\
**Post date:** [September 17, 2024, 9:10am UTC](https://forum.codecrafters.io/t/grep-shouldnt-be-added-more-test-to-be-correct/1809/1 "2024-09-17T09:10:34Z")

</div>

Hi everybody,  
I think tests should include something like this to be correct :

```auto
{
  Pattern : ca+t
  Input: ca
  ExpectedExitCode: 1
}

```

as for now there is no case tested where the mandatory chars after the + operator are missing or wrong.

---

<div class="post-metadata">

**Author:** ![andy1li](https://yyz1.discourse-cdn.com/flex003/user_avatar/forum.codecrafters.io/andy1li/32/10_2.png) [@andy1li](https://forum.codecrafters.io/u/andy1li)\
**Post date:** [October 4, 2024, 1:34am UTC](https://forum.codecrafters.io/t/grep-shouldnt-be-added-more-test-to-be-correct/1809/2 "2024-10-04T01:34:29Z")

</div>

Thanks, @giuseppe-osenda, for highlighting this. I’ve turned your feedback into an internal ticket and will ensure it’s handled as soon as possible. I’ll keep you updated on the progress.

---

<div class="post-metadata">

**Author:** ![system](https://canada1.discourse-cdn.com/flex003/uploads/codecrafters/original/3X/7/0/700657133935c15703e22c7c8870394f6e6dc27d.svg) [@system](https://forum.codecrafters.io/u/system)\
**Post date:** [October 9, 2024, 6:50am UTC](https://forum.codecrafters.io/t/grep-shouldnt-be-added-more-test-to-be-correct/1809/4 "2024-10-09T06:50:00Z")

</div>

Closed on October 9, 2024, 6:50am UTC

This topic was automatically closed 5 days after the last reply. New replies are no longer allowed.

---

<div class="post-metadata">

**Author:** ![andy1li](https://yyz1.discourse-cdn.com/flex003/user_avatar/forum.codecrafters.io/andy1li/32/10_2.png) [@andy1li](https://forum.codecrafters.io/u/andy1li)\
**Post date:** [October 15, 2024, 7:39am UTC](https://forum.codecrafters.io/t/grep-shouldnt-be-added-more-test-to-be-correct/1809/5 "2024-10-15T07:39:07Z")

</div>

@giuseppe-osenda We’ve updated the test cases via [this PR](https://github.com/codecrafters-io/grep-tester/pull/30). Thanks again for bringing this to our attention!